test: refactor test-fs-read-zero-length.js #10729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
|
Unfortunately I need to add it to that PR, otherwise I get linter errors. The other change looks good though. |
mscdex
added
fs
jasnell
approved these changes
Jan 10, 2017
cjihrig
approved these changes
Jan 11, 2017
hiroppy
force-pushed
the
feature/refactor-test-fs-read-zero-length.js
branch
from
5632650 to
87461e8
Compare
|
Landed d86ff5f |
italoacasas
pushed a commit
that referenced
this pull request
Jan 17, 2017
PR-URL: #10729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
PR-URL: nodejs#10729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
PR-URL: #10729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
PR-URL: #10729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
this will need a backport pr if it needs to land in v4 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #10729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
equalwithstrictEqual.There is not this file in #10698.
Rebased because of the influence of #10698.
All replacement of
equalanddeepEqualis complete :)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test